[Improve][Connector-V2] Improve schema evolution on column insert after for mysql-jdbc #8017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Hisoka-X
reviewed
Nov 12, 2024
| columns.stream() | ||
| .filter(column -> afterColumn.equals(column.getName())) | ||
| .findFirst(); | ||
| columnOptional.ifPresent( |
There was a problem hiding this comment.
if not present (basically not happen, but we should care about it), it will lose column?
There was a problem hiding this comment.
thanks,I will fix it
Hisoka-X
changed the title
…ing with Elasticsearch's automatic index creation apache#7430
…utomatic index creation conflict apache#7430
…utomatically creating indexes based on templates apache#7430
…utomatic index creation conflict apache#7430
Hisoka-X
force-pushed
the
column-insertion
branch
from
84f6bc7 to
82e6f6a
Compare
hailin0
approved these changes
Nov 16, 2024
fcb-xiaobo
pushed a commit
to fcb-xiaobo/seatunnel
that referenced
this pull request
Nov 18, 2024
…er for mysql-jdbc (apache#8017)
fcb-xiaobo
pushed a commit
to fcb-xiaobo/seatunnel
that referenced
this pull request
Nov 18, 2024
…er for mysql-jdbc (apache#8017)
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Nov 18, 2024
…er for mysql-jdbc (apache#8017)
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Nov 18, 2024
…er for mysql-jdbc (apache#8017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve #8015
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.