Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][zeta]Support exposing monitoring metrics by prometheus exporter protocol #7564

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Sep 3, 2024

Purpose of this pull request

issue: #7539

ing: :>

  1. Provides complete grafana config template
  2. Testing
  3. Continue to add indicators,See doc for details(comments are welcome)

Does this PR introduce any user-facing change?

How was this patch tested?

e2e

Check list

@github-actions github-actions bot added document dependencies Pull requests that update a dependency file core SeaTunnel core module Zeta Zeta Rest API e2e labels Sep 3, 2024
@Hisoka-X
Copy link
Member

Hisoka-X commented Sep 4, 2024

cc @hailin0

docs/en/seatunnel-engine/telemetry.md Outdated Show resolved Hide resolved
docs/en/seatunnel-engine/telemetry.md Show resolved Hide resolved
docs/zh/seatunnel-engine/telemetry.md Outdated Show resolved Hide resolved
docs/en/seatunnel-engine/telemetry.md Outdated Show resolved Hide resolved
@Hisoka-X
Copy link
Member

Hisoka-X commented Sep 4, 2024

The grafana-dashboard.json is empty. Please update it.

@corgy-w
Copy link
Contributor Author

corgy-w commented Sep 4, 2024

The grafana-dashboard.json is empty. Please update it.

@Hisoka-X As mentioned above, grafana template will have to wait a little longer, but this week

@hailin0
Copy link
Member

hailin0 commented Sep 4, 2024

good job

@hailin0
Copy link
Member

hailin0 commented Sep 4, 2024

Please add monitoring screenshots of grafana

@Hisoka-X Hisoka-X added this to the 2.3.8 milestone Sep 5, 2024
@corgy-w
Copy link
Contributor Author

corgy-w commented Sep 7, 2024

PTAL @Hisoka-X @hailin0

config/seatunnel.yaml Outdated Show resolved Hide resolved
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minior change.

| jvm_buffer_pool_capacity_bytes | Gauge | **池**,包括:"direct" "mapped" | 给定 JVM 缓冲池的字节容量 |
| jvm_buffer_pool_used_buffers | Gauge | **池**,包括:"direct" "mapped" | 给定 JVM 缓冲池使用的缓冲区 |

### 通过 Prometheus 和 Grafana 进行集群监控
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 通过 Prometheus 和 Grafana 进行集群监控
## 通过 Prometheus 和 Grafana 进行集群监控

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get , revised doc⬇️

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @corgy-w !

@hailin0 hailin0 merged commit b8bc2b0 into apache:dev Sep 9, 2024
8 checks passed
Comment on lines +24 to +28
The [metric text of prometheus](./telemetry/metrics.txt),which get
from `http:{instanceHost}:5801/hazelcast/rest/instance/metrics`.

The [metric text of openMetrics](./telemetry/openmetrics.txt),which get
from `http:{instanceHost}:5801/hazelcast/rest/instance/openmetrics`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The http path looks not right, it missed //. Could you create a PR to correct it? @corgy-w

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get

LeonYoah pushed a commit to LeonYoah/seatunnel that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved core SeaTunnel core module dependencies Pull requests that update a dependency file document e2e reviewed Zeta Rest API Zeta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants