[Improve][Zeta] Move SaveMode behavior to master #6843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
changed the title
dailai
reviewed
May 13, 2024
| for (LogicalEdge edge : edges) { | ||
| out.writeObject(edge); | ||
| } | ||
|
|
||
| out.writeInt(saveModeList.size()); | ||
| for (SupportSaveMode saveMode : saveModeList) { |
There was a problem hiding this comment.
Should we consider the DataSerializable of this?
There was a problem hiding this comment.
In fact, the current SupportSaveMode declarations are all on the SeaTunnelSink implementation class, and all SeaTunnelSinks are serializable by default. It is also engine-independent.
Hisoka-X
force-pushed
the
savemode-to-master
branch
from
aeaa2e0 to
a7c04b7
Compare
hailin0
reviewed
Jun 7, 2024
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SaveModeExecuteLocation.java
Show resolved
Hide resolved
hailin0
reviewed
Jun 7, 2024
...atunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java
Show resolved
Hide resolved
|
Please fix ci error |
done |
EricJoy2048
approved these changes
Jun 13, 2024
3 tasks
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR move savemode logic into master node.
Mainly for two purposes:
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide
release-note.