[Bugfix] [seatunnel-starter] When inside double quotes,',' are treated as normal characters instead of delimiters

seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/AbstractCommandArgs.java

@@ -42,7 +42,9 @@ public abstract class AbstractCommandArgs extends CommandArgs {
     @Parameter(
             names = {"-i", "--variable"},
             splitter = ParameterSplitter.class,
-            description = "Variable substitution, such as -i city=beijing, or -i date=20190318")
+            description =
+                    "Variable substitution, such as -i city=beijing, or -i date=20190318."
+                            + "We use ',' as separator, when inside \"\", ',' are treated as normal characters instead of delimiters.")
     protected List<String> variables = Collections.emptyList();
 
     /** check config flag */

seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/ParameterSplitter.java

@@ -19,29 +19,29 @@
 import com.beust.jcommander.converters.IParameterSplitter;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 
 public class ParameterSplitter implements IParameterSplitter {
 
     @Override
     public List<String> split(String value) {
-        if (!value.contains(",")) {
-            return Collections.singletonList(value);
-        }
 
         List<String> result = new ArrayList<>();
         StringBuilder currentToken = new StringBuilder();
         boolean insideBrackets = false;
+        boolean insideQuotes = false;
 
         for (char c : value.toCharArray()) {
+
             if (c == '[') {
                 insideBrackets = true;
             } else if (c == ']') {
                 insideBrackets = false;
+            } else if (c == '"') {
+                insideQuotes = !insideQuotes;
             }
 
-            if (c == ',' && !insideBrackets) {
+            if (c == ',' && !insideQuotes && !insideBrackets) {
                 result.add(currentToken.toString().trim());
                 currentToken = new StringBuilder();
             } else {

seatunnel-core/seatunnel-starter/src/test/java/org/apache/seatunnel/core/starter/seatunnel/args/ClientCommandArgsTest.java

@@ -58,6 +58,8 @@ public void testUserDefinedParamsCommand() throws URISyntaxException {
             "username=" + username,
             "-i",
             "list=" + list,
+            "-i",
+            "sql=" + "\"select a , b from fake_source_table\""
         };
         ClientCommandArgs clientCommandArgs =
                 CommandLineUtils.parse(args, new ClientCommandArgs(), "seatunnel-zeta", true);
@@ -94,6 +96,8 @@ public void testUserDefinedParamsCommand() throws URISyntaxException {
             List<String> list1 = sinkConfig.getStringList("list");
             Assertions.assertEquals(list1.get(0), "par1=20230829");
             Assertions.assertEquals(list1.get(1), "par2=20230829");
+            String sql = sinkConfig.getString("sql");
+            Assertions.assertEquals(sql, "\"select a , b from fake_source_table\"");
         }
     }
 }

seatunnel-core/seatunnel-starter/src/test/resources/args/user_defined_params.conf

@@ -47,5 +47,6 @@ sink {
      username = ${username}
      password = ${password}
      list = ${list}
+     sql = ${sql}
   }
 }