Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][ElasticsearchSink]Update the version in the docs. #4499

Merged
merged 4 commits into from
May 17, 2023

Conversation

lightzhao
Copy link
Contributor

Purpose of this pull request

The test found that the 6.x version cannot be supported.
image

Check list

@TyrantLucifer
Copy link
Member

@iture123 PTAL

@lightzhao
Copy link
Contributor Author

@iture123 @TyrantLucifer @Hisoka-X PTAL,thanks.

Hisoka-X
Hisoka-X previously approved these changes Apr 10, 2023
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The owner @iture123 of es connector has the different thoughts of this, later he will left his advice.

Copy link
Contributor

@iture123 iture123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ElasticsearchRowSerializer make an error annotation,The elasticsearch connector and the class ElasticsearchRowSerializer.java both support ElasticSearch version is >= 2.x and <= 8.x.

@lightzhao
Copy link
Contributor Author

error annotation,

ok, fix error annotation.

@lightzhao
Copy link
Contributor Author

@TyrantLucifer @iture123 @Hisoka-X PTAL.

@lightzhao
Copy link
Contributor Author

who has time help review, thanks.

@TyrantLucifer
Copy link
Member

merge dev into your branch

@lightzhao
Copy link
Contributor Author

merge dev into your branch

done.

@EricJoy2048
Copy link
Member

@TyrantLucifer @iture123 @Hisoka-X PTAL again.

@TyrantLucifer TyrantLucifer merged commit 4151506 into apache:dev May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants