Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][CDC] Fix concurrent modify of splits #3937

Merged
merged 1 commit into from
Jan 14, 2023
Merged

[Bug][CDC] Fix concurrent modify of splits #3937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...g/apache/seatunnel/connectors/cdc/base/source/enumerator/IncrementalSourceEnumerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ public void open() {
}

@Override
public void run() throws Exception {
public synchronized void run() throws Exception {
this.running = true;
assignSplits();
}

@Override
public void handleSplitRequest(int subtaskId) {
public synchronized void handleSplitRequest(int subtaskId) {
if (!context.registeredReaders().contains(subtaskId)) {
// reader failed between sending the request and now. skip this request.
return;
Expand Down Expand Up @@ -128,7 +128,7 @@ public PendingSplitsState snapshotState(long checkpointId) {
}

@Override
public void notifyCheckpointComplete(long checkpointId) {
public synchronized void notifyCheckpointComplete(long checkpointId) {
splitAssigner.notifyCheckpointComplete(checkpointId);
// incremental split may be available after checkpoint complete
assignSplits();
Expand Down