[Feature][Shade] Add seatunnel hadoop3 uber #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grypse
suggested changes
Dec 19, 2022
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-iceberg-flink-e2e/pom.xml
Show resolved
Hide resolved
|
Please check CI errors. |
Grypse
reviewed
Dec 19, 2022
| <artifactId>seatunnel-shade</artifactId> | ||
| <packaging>pom</packaging> | ||
| <modules> | ||
| <module>seatunnel-hadoop3-3.1.4-uber</module> |
There was a problem hiding this comment.
I think the name of seatunnel-hadoop3-shade may be better.There's no need to add hadoop version to module name.
There was a problem hiding this comment.
I think the name of seatunnel-hadoop3-shade may be better.There's no need to add hadoop version to module name.
I don't think so. We will add more hadoop version shaded jar in the next version.
Grypse
reviewed
Dec 19, 2022
EricJoy2048
force-pushed
the
add_seatunnel_hadoop_uber
branch
from
924b421 to
8ce8a79
Compare
TyrantLucifer
approved these changes
Dec 21, 2022
liugddx
reviewed
Dec 22, 2022
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-iceberg-flink-e2e/pom.xml
Show resolved
Hide resolved
...l-engine/seatunnel-engine-storage/checkpoint-storage-plugins/checkpoint-storage-hdfs/pom.xml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now many module test used
flink shade hadoop, We tested useflink shade hadoopjar will trigger jackson jar conflict when we useMySQL CDC Source. So we add a seatunnel owner hadoop shaded uber jar.