-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][Core] Fix Handover using linked blocking queue cause the oom #3469
Conversation
@ashulin PTAL. |
this.lock = new ReentrantLock(); | ||
this.isNotFull = lock.newCondition(); | ||
|
||
this.queue = new ArrayDeque<>(DEFAULT_QUEUE_SIZE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use ArrayBlockingQueue
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, Add a default capacity to LinkedBlockingQueue
agree with you @harveyyue please use |
hi, how is the progress? |
71506ed
to
e4b0945
Compare
… the oom" This reverts commit e4b0945.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix following OOM with spark engine.
Purpose of this pull request
Check list
New License Guide