Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2] Add iceberg source connector #2615

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Sep 2, 2022

Purpose of this pull request

close #2495

Check list

@hailin0
Copy link
Member Author

hailin0 commented Sep 3, 2022

@hailin0
Copy link
Member Author

hailin0 commented Sep 7, 2022

image

Disable unit tests for now.

Caused by: java.lang.UnsupportedOperationException: 'posix:permissions' not supported as initial attribute

@hailin0
Copy link
Member Author

hailin0 commented Sep 7, 2022

image

@ic4y
Copy link
Contributor

ic4y commented Sep 8, 2022

Whether the source implements the SupportCoordinate interface, if not, it should be noted that each reader will run a enumerator。

@hailin0
Copy link
Member Author

hailin0 commented Sep 8, 2022

Whether the source implements the SupportCoordinate interface, if not, it should be noted that each reader will run a enumerator。

The SupportCoordinate interface only allows tasks to run multi-threaded on a single node.if the invariant split is guaranteed on Enumerator, it can be run on multiple nodes concurrently

https://github.com/apache/incubator-seatunnel/pull/2615/files#diff-411640dd67287ac737c410ce2855f03fe9152b54857954ad3b74a5411948988eR106-R109

@hailin0 hailin0 force-pushed the iceberg-source branch 3 times, most recently from db720e5 to 6665875 Compare September 13, 2022 02:44
EricJoy2048
EricJoy2048 previously approved these changes Sep 13, 2022
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 force-pushed the iceberg-source branch 2 times, most recently from c480de4 to 731d331 Compare September 14, 2022 13:22
EricJoy2048
EricJoy2048 previously approved these changes Sep 15, 2022
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit ffc6088 into apache:dev Sep 16, 2022
TyrantLucifer pushed a commit to TyrantLucifer/incubator-seatunnel that referenced this pull request Sep 18, 2022
* [Feature][Connector-V2] Add iceberg source connector
Co-authored-by: wanghailin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Connector-v2] Support iceberg source
5 participants