-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] Add iceberg source connector #2615
Conversation
@TyrantLucifer @531651225 @laglangyue @iture123 @liugddx @wuchunfu @guanboo |
Whether the source implements the SupportCoordinate interface, if not, it should be noted that each reader will run a enumerator。 |
...org/apache/seatunnel/connectors/seatunnel/iceberg/source/split/IcebergFileScanTaskSplit.java
Outdated
Show resolved
Hide resolved
The SupportCoordinate interface only allows tasks to run multi-threaded on a single node.if the invariant split is guaranteed on Enumerator, it can be run on multiple nodes concurrently |
db720e5
to
6665875
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...rg/src/test/java/org/apache/seatunnel/connectors/seatunnel/iceberg/TestIcebergMetastore.java
Outdated
Show resolved
Hide resolved
c480de4
to
731d331
Compare
731d331
to
702bd33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
* [Feature][Connector-V2] Add iceberg source connector Co-authored-by: wanghailin <[email protected]>
Purpose of this pull request
close #2495
Check list
New License Guide