[Bug][Zeta] Fix TaskExecutionService synchronized lock will not relea…

…se (#4886)
apache · Jun 6, 2023 · c7745e6 · c7745e6
1 parent 5e03d22
commit c7745e6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/...-engine-server/src/main/java/org/apache/seatunnel/engine/server/TaskExecutionService.java b/...-engine-server/src/main/java/org/apache/seatunnel/engine/server/TaskExecutionService.java
@@ -507,7 +507,7 @@ public void provideDynamicMetrics(
         }
     }
 
-    private synchronized void updateMetricsContextInImap() {
+    private void updateMetricsContextInImap() {
         if (!nodeEngine.getNode().getState().equals(NodeState.ACTIVE)) {
             logger.warning(
                     String.format(
@@ -542,7 +542,11 @@ private synchronized void updateMetricsContextInImap() {
                 });
         if (localMap.size() > 0) {
             try {
-                metricsImap.lock(Constant.IMAP_RUNNING_JOB_METRICS_KEY);
+                if (!metricsImap.tryLock(
+                        Constant.IMAP_RUNNING_JOB_METRICS_KEY, 2, TimeUnit.SECONDS)) {
+                    logger.info("try lock failed in update metrics");
+                    return;
+                }
                 HashMap<TaskLocation, SeaTunnelMetricsContext> centralMap =
                         metricsImap.computeIfAbsent(
                                 Constant.IMAP_RUNNING_JOB_METRICS_KEY, k -> new HashMap<>());