Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Seatunnel-web]Add support to configure placeholder with default value in the job config. #208

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

arshadmohammad
Copy link
Collaborator

Purpose of this pull request

Check list

@arshadmohammad arshadmohammad marked this pull request as draft September 7, 2024 08:58
@arshadmohammad arshadmohammad self-assigned this Sep 7, 2024
@arshadmohammad
Copy link
Collaborator Author

arshadmohammad commented Sep 7, 2024

The primary modification in this Pull Request focuses on org.apache.seatunnel.app.utils.JobUtils#replaceJobConfigPlaceholders and its application.

I am currently encountering an issue when ${configParam:default} is set in the job configuration.
The ConfigFactory.parseString(jobConfigString) operation fails with the error:
String: 1: Token not allowed in path expression: ':' (you can double-quote this token if you really want it here).

I plan to investigate the variable substitution implementation on the Seatunnel engine side.

@arshadmohammad
Copy link
Collaborator Author

Executed integration tests, all are passed
image

Manually tested conditional query
image

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @arshadmohammad !

@Hisoka-X Hisoka-X merged commit 70e526a into apache:main Sep 9, 2024
15 checks passed
@arshadmohammad
Copy link
Collaborator Author

Thanks @Hisoka-X for reviewing and merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants