Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Seatunnel-web] Task instance filter is not working as expected #204

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

arshadmohammad
Copy link
Collaborator

Corredcted task instance filter logic
Changed logback version to 1.2.3

Purpose of this pull request

Check list

@arshadmohammad
Copy link
Collaborator Author

Modified existing test case to verify the filter scenario. executed all integration test cases
image

@arshadmohammad
Copy link
Collaborator Author

After fix, filter is working as expected
image

@Hisoka-X
Copy link
Member

Hisoka-X commented Sep 5, 2024

Please fix ci.

@arshadmohammad
Copy link
Collaborator Author

Seems PR CI is failed because of CI environment issue
Error: Failed to execute goal on project seatunnel-dynamicform: Could not resolve dependencies for project org.apache.seatunnel:seatunnel-dynamicform:jar:1.0.2-SNAPSHOT: Could not transfer artifact com.fasterxml.jackson.core:jackson-databind:jar:2.12.6 from/to central (https://repo.maven.apache.org/maven2): /home/runner/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.12.6/jackson-databind-2.12.6.jar.part (No such file or directory)

Let me retrigger the PR CI by pushing dummy change.

@arshadmohammad
Copy link
Collaborator Author

Backend / Integration Test (11, ubuntu-latest) (pull_request) Failed

Error: /home/runner/work/seatunnel-web/seatunnel-web/seatunnel-server/seatunnel-server-common/src/main/java/org/apache/seatunnel/server/common/CodeGenerateUtils.java:[22,12] cannot access java.util
Error: ZipException opening "seatunnel-jackson-2.3.7-optional.jar": zip END header not found

…o taskName as taskName is referred everywhere in UI.
@arshadmohammad
Copy link
Collaborator Author

Finally build is success.

@@ -105,7 +105,7 @@
<hadoop-aws.version>3.1.4</hadoop-aws.version>
<aws-java-sdk-bundle.version>1.11.271</aws-java-sdk-bundle.version>
<spotless.version>2.29.0</spotless.version>
<logback.version>1.5.7</logback.version>
<logback.version>1.2.3</logback.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we should downgrade logback version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Despite upgrading to version 1.5.7, there remains an unresolved Common Vulnerabilities and Exposures (CVE) issue in this version.
  2. Upon upgrading to 1.5.7, the log4j-slf4j-impl jar file is absent from the project, resulting in failed logging attempts.

So reverted as of now. Will check more on this later

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @arshadmohammad

@Hisoka-X Hisoka-X merged commit 36c85cc into apache:main Sep 5, 2024
15 checks passed
@arshadmohammad arshadmohammad self-assigned this Sep 6, 2024
@arshadmohammad
Copy link
Collaborator Author

Thanks @Hisoka-X for reviewing and merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants