Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMZA-2776: Upgrade Azure libraries in module samza-azure. #1660

Merged
merged 6 commits into from
Jun 12, 2023

Conversation

ehoner
Copy link
Contributor

@ehoner ehoner commented Apr 3, 2023

Issues

The com.azure and com.microsoft dependencies in samza-azure are outdated. These should be updated to their newest versions. These libraries have undergone significant changes and are available only in their legacy locations.

Changes

No changes are made to Samza's public APIs. All changes are required by changes in the updated libraries. No unit tests were changed. An itemized description of the underlying changes is below.

The file samza-azure/samza-azure-dependencies.txt was added and removed, intended for review/discussion purposes only [de23888].

EventHubClient.java

  1. Public method renamed.
    1. createSync => createFromConnectionStringSync
    2. Event Hubs Java RBAC support Azure/azure-sdk-for-java#4498
  2. Public method parameter changed.
    1. Exector => ScheduledExecutorService
    2. (large refactor) - Azure/azure-sdk-for-java/a8c2f43 -- see git-subtree-split: e68c319

EventData.java

  1. Added new public method.
    1. void setSystemProperties(SystemProperties props);
    2. Pull latest changes from azure-event-hubs-java Azure/azure-sdk-for-java#3474
    3. Implementation copied from EventData.java.
  2. Implements Comparable<EventData>
    1. (large refactor) - Azure/azure-sdk-for-java/e68c319

PartitionReceiver.java

  1. Removed public APIs
    1. void setPrefetchCount(final int prefetchCount) throws EventHubException;
    2. (large refactor) - Azure/azure-sdk-for-java/e68c319
    3. Requires use of RecieverOptions object (no functionality lost).

Tests

No tests added. All tests are passing.

@ehoner
Copy link
Contributor Author

ehoner commented Jun 9, 2023

@hshukla

@atoomula atoomula merged commit 7020e3a into apache:master Jun 12, 2023
@ehoner ehoner deleted the SAMZA-2776 branch June 12, 2023 23:58
Comment on lines +284 to +285
ReceiverOptions receiverOptions = new ReceiverOptions();
receiverOptions.setPrefetchCount(prefetchCount);
Copy link
Contributor Author

@ehoner ehoner Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value is unused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants