-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message test #32
base: master
Are you sure you want to change the base?
Add message test #32
Conversation
e56942d
to
d64e4a4
Compare
golang/utils/CheckUtils.go
Outdated
recvMsg = string(recv.GetBody()) | ||
} | ||
|
||
assert.Equal(t, sendMsg, recvMsg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check逻辑是否合理?看起来好像只check了最后一条消息body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check这里后面还会完善
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有完善的代码不应该提交pr。
} | ||
|
||
if tt.args.keys != "" { | ||
// 设置消息索引键,可根据关键字精确查找某条消息。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个判断是否有必要?
golang/message/delay_test.go
Outdated
t.Errorf("failed to send delay message, err:%s", err) | ||
} | ||
for i := 0; i < len(resp); i++ { | ||
fmt.Printf("%#v\n", resp[i]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是否有必要打印resp
9619e95
to
41121bc
Compare
add message test