Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message test #32

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

Stevent-fei
Copy link

@Stevent-fei Stevent-fei commented May 24, 2023

add message test

@Stevent-fei Stevent-fei force-pushed the add_normal_test branch 3 times, most recently from e56942d to d64e4a4 Compare May 26, 2023 08:01
@Stevent-fei Stevent-fei changed the title Add normal and delay test Add message test May 30, 2023
recvMsg = string(recv.GetBody())
}

assert.Equal(t, sendMsg, recvMsg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check逻辑是否合理?看起来好像只check了最后一条消息body

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check这里后面还会完善

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有完善的代码不应该提交pr。

}

if tt.args.keys != "" {
// 设置消息索引键,可根据关键字精确查找某条消息。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个判断是否有必要?

t.Errorf("failed to send delay message, err:%s", err)
}
for i := 0; i < len(resp); i++ {
fmt.Printf("%#v\n", resp[i])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否有必要打印resp

@Stevent-fei Stevent-fei changed the title Add message test 【WIP】Add message test Jun 5, 2023
@Stevent-fei Stevent-fei changed the title 【WIP】Add message test Add message test Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants