Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #989] consumer and producer client add unit support (WithUnitName) #988

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

twz915
Copy link
Contributor

@twz915 twz915 commented Jan 31, 2023

What is the purpose of the change

#989

Support unit producer/consumer.
Supports consuming messages from Unit2 in Unit1

rocketmq.NewPushConsumer(
	consumer.WithGroupName(s.GroupID),
	consumer.WithNameServerDomain(s.NameServerURL),
	consumer.WithUnitName("unsh"),
	consumer.WithInstanceName("unsh"),
	...
)


rocketmq.NewProducer(
	producer.WithGroupName(s.GroupID),
	producer.WithNameServerDomain(s.NameServerURL),
	producer.WithUnitName("unsh"),
	producer.WithInstanceName("unsh"),
	...
)

@twz915 twz915 changed the title support unit producer/consumer [ISSUE #989] support unit producer/consumer Jan 31, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #988 (3a92798) into master (896a8a3) will decrease coverage by 0.07%.
The diff coverage is 15.15%.

@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
- Coverage   23.32%   23.26%   -0.07%     
==========================================
  Files          52       52              
  Lines        7266     7294      +28     
==========================================
+ Hits         1695     1697       +2     
- Misses       5339     5363      +24     
- Partials      232      234       +2     
Impacted Files Coverage Δ
consumer/option.go 18.18% <0.00%> (-1.66%) ⬇️
producer/option.go 32.87% <0.00%> (-5.84%) ⬇️
primitive/nsresolver.go 53.09% <55.55%> (-1.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@twz915 twz915 force-pushed the patch-4 branch 2 times, most recently from cb8da2a to 5dd59d7 Compare February 1, 2023 02:32
@twz915 twz915 changed the title [ISSUE #989] support unit producer/consumer [ISSUE #989] producer and consumer name server domain support unit mode Feb 1, 2023
@francisoliverlee francisoliverlee linked an issue Feb 7, 2023 that may be closed by this pull request
@twz915 twz915 mentioned this pull request Apr 4, 2023
5 tasks
@twz915 twz915 changed the title [ISSUE #989] producer and consumer name server domain support unit mode [ISSUE #989] consumer and producer client add unit support (WithUnitName) Apr 5, 2023
@ShannonDing ShannonDing merged commit 7f3ffe2 into apache:master Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support unit producer/consumer.
4 participants