Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #945]init crCh after topic with namespace to avoid consumption blocked. #944

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

NeonToo
Copy link
Contributor

@NeonToo NeonToo commented Oct 13, 2022

…se consumption blocked; opt on log

What is the purpose of the change

close #945

  • the consumption blocked unexpectly since the crCh map key is without topic namespace
  • more log info for some cases

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@0daypwn
Copy link
Contributor

0daypwn commented Oct 14, 2022

#933 #934
It should be the same problem.Retry topic also needs to be considered.

@NeonToo NeonToo closed this Oct 14, 2022
@NeonToo NeonToo reopened this Oct 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #944 (003b83f) into master (8011561) will increase coverage by 0.04%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##           master     #944      +/-   ##
==========================================
+ Coverage   23.61%   23.65%   +0.04%     
==========================================
  Files          52       52              
  Lines        7170     7179       +9     
==========================================
+ Hits         1693     1698       +5     
- Misses       5247     5251       +4     
  Partials      230      230              
Impacted Files Coverage Δ
consumer/consumer.go 17.61% <0.00%> (ø)
internal/client.go 0.17% <0.00%> (-0.01%) ⬇️
internal/constants.go 0.00% <0.00%> (ø)
consumer/push_consumer.go 13.29% <100.00%> (+0.48%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ShannonDing ShannonDing changed the title init crCh after topic with namespace instead of before which will cau… [ISSUE #945]init crCh after topic with namespace to avoid consumption blocked. Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the consumption blocked unexpectedly since the crCh map key is without topic namespace.
4 participants