Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #899]Fix the groupName takes the namespace prefix #900

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

zhangjidi2016
Copy link
Contributor

What is the purpose of the change

#899

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of consumer groups may be the same in different namespaces, so IMO it's necessary to keep the namespace.

@zhangjidi2016
Copy link
Contributor Author

The name of consumer groups may be the same in different namespaces, so IMO it's necessary to keep the namespace.

I don't think so. Firstly, namespace is a resource isolation to prevent topic or group names. For users, the topic or group without namespace is set in the client code, while adding namespace prefix to topic or group is handled in the program. The direct display of namespace prefix may cause confusion to the user. Secondly, other language clients such as Java remove the prefix of the above problems, which should be kept consistent.

@lizhanhui
Copy link

Secondly, other language clients such as Java remove the prefix of the above problems, which should be kept consistent.

Agree. It's essential to maintain consistency among different bindings.

@ShannonDing ShannonDing merged commit 39619b9 into apache:master Aug 24, 2022
@zongtanghu
Copy link

LGTM

@zhangjidi2016 zhangjidi2016 deleted the groupName_with_namespace branch August 24, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants