Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #869] Fix: Consumer api comments #867

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Jul 25, 2022

What is the purpose of the change

close #869 Fix consumer api comments in api.go

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing changed the title Fix: Consumer api comments [ISSUE #869] Fix: Consumer api comments Jul 25, 2022
@ShannonDing ShannonDing added this to the 2.1.1 milestone Jul 25, 2022
@ShannonDing ShannonDing added the doc Document, comments and clean code label Jul 25, 2022
@ShannonDing ShannonDing merged commit 595f2d9 into apache:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Document, comments and clean code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments error in push consumer
4 participants