Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #726] feat: replace fmt to rlog #756

Merged
merged 5 commits into from
Dec 22, 2021

Conversation

yuanmoon
Copy link
Contributor

What is the purpose of the change

#726

Brief changelog

Replace fmt to rlog

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@yuanmoon
Copy link
Contributor Author

It seems that the failure of Travis CI is caused by this bug(#757).
And here is the bug fix pr(#758).
So grateful if someone can help to confirm this.

@wenfengwang
Copy link
Member

@yuanmoon Hi, the directory of examples is the demo for users for their business, so, we can not use rlog in these files

@yuanmoon
Copy link
Contributor Author

@wenfengwang
Thanks for review. I just follow your advice to roll back code. You can check again and please let me know if there are still places that need to be modified.

@wenfengwang wenfengwang merged commit de5f561 into apache:master Dec 22, 2021
@ShannonDing ShannonDing added this to the 2.2.0 milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants