[ISSUE #744] check multiple topics in one batch #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaOreoreorui Good job! Could you create a related issue pls? |
MaOreoreorui
changed the title
done 👨🏻💻 |
vongosling
approved these changes
Nov 29, 2021
|
Would you like to add a test for your pr? |
MaOreoreorui
force-pushed
the
master
branch
3 times, most recently
from
aae593e
to
1b7e7e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
issue #744
Because of the lack of pre-check, the message will be sent to the first topic when batch sending messages to multiple topics.
Brief changelog
add check logic in func [ defaultProducer.checkMsg(msgs ...*primitive.Message) error ]