feat: batchSend messages return result has msgIds and offsetMsgId #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twz915 大佬，空了给看看，帮merge下呗 |
yuz10
reviewed
Oct 14, 2024
| @@ -69,6 +69,7 @@ const ( | |||
| ) | |||
|
|
|||
| type Message struct { | |||
| List []*Message | |||
There was a problem hiding this comment.
the list is used internal, should not export to public interface. so might be better to pass msgs to ProcessSendResponse function through function call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
batchSend messages return result has msgIds and offsetMsgId
Brief changelog
XX
Verifying this change
batchSend result before
batchSend result now