Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #999]support admin topicList and groupList method #1000

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

Slideee
Copy link
Contributor

@Slideee Slideee commented Feb 13, 2023

What is the purpose of the change

#999

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@francisoliverlee francisoliverlee added the enhancement New feature or request label Feb 14, 2023
@francisoliverlee francisoliverlee linked an issue Feb 14, 2023 that may be closed by this pull request
@francisoliverlee francisoliverlee added the good first issue Good for newcomers label Feb 14, 2023
Copy link
Member

@francisoliverlee francisoliverlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实现最好和java保持一致。

  1. 方法名GroupList 对应 getAllSubscriptionGroupadmin;TopicList 对应 fetchAllTopicList
  2. 通信层返回的RemotingCommand,admin这一层的返回值建议做成明确的struct

admin/admin.go Outdated
Comment on lines 37 to 38
GroupList(ctx context.Context, brokerAddr string) (*remote.RemotingCommand, error)
TopicList(ctx context.Context) (*remote.RemotingCommand, error)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实现最好和java保持一致。

  1. 方法名GroupList 对应 getAllSubscriptionGroupadmin;TopicList 对应 fetchAllTopicList
  2. 通信层返回的RemotingCommand,admin这一层的返回值建议做成明确的struct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@Slideee Slideee requested review from francisoliverlee and removed request for maixiaohai February 22, 2023 06:01
Copy link
Member

@francisoliverlee francisoliverlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOGT

@francisoliverlee francisoliverlee merged commit ae93d2a into apache:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support admin topicList and groupList method
2 participants