Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master][Bug] takeMessage can't quit when pullRequest is Dropped #628

Closed
qianlongzt opened this issue Mar 15, 2021 · 1 comment · Fixed by #629
Closed

[Master][Bug] takeMessage can't quit when pullRequest is Dropped #628

qianlongzt opened this issue Mar 15, 2021 · 1 comment · Fixed by #629
Labels
discuss Something undering disscussing enhancement New feature or request

Comments

@qianlongzt
Copy link
Contributor

consumeMessageOrderly

when no message in cache and pullRequest is droped,takeMessage can't quit

func (pq *processQueue) takeMessages(number int) []*primitive.MessageExt {
for pq.msgCache.Empty() {
time.Sleep(10 * time.Millisecond)
}

qianlongzt added a commit to qianlongzt/rocketmq-client-go that referenced this issue Mar 16, 2021
@wenfengwang wenfengwang added discuss Something undering disscussing enhancement New feature or request labels Jul 1, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale stale bot closed this as completed Apr 30, 2022
@ShannonDing ShannonDing reopened this Jul 21, 2022
@ShannonDing ShannonDing modified the milestone: 2.1.0 Jul 21, 2022
@stale stale bot removed the stale label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Something undering disscussing enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants