-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 7450][conf] add gc log print for broker #7498
Conversation
/pulsarbot run-failure-checks |
Wouldn't the GC CLI options be adapted when JVM > 1.8? |
What's your meaning ? You want to tune gc options when jvm > 1.8? If you want to ask if gc log option can work in jvm11 or later ? It can work. |
@Shoothzj At least |
@Shoothzj Could you please take a look at the last comment? |
I make it compat on two major java release. java8 and java11. |
@Shoothzj Seems after apply your last commit, the GC log only can enable in JDK 8 and JDK 11 right? |
Yes. It's two mostly use major release version of java. Can we ignore the version less than 8 ? Then I can make it works on jdk 8 and later. |
Fixes apache#7450 ### Motivation Gc log is a useful tool to help our positioning our jvm runing situation. It can use to solve gc param is not reasonable, memory leak. I think if pulsar need this too.
Fixes #7450
Motivation
Gc log is a useful tool to help our positioning our jvm runing situation. It can use to solve gc param is not reasonable, memory leak. I think if pulsar need this too.
Modifications
I modified start script, add gc log param.
Does this pull request potentially affect one of the following parts:
added jvm param.