[fix][test] Fix quiet time implementation in BrokerTestUtil.receiveMessages #23876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lhotari
requested review from
nodece,
dao-jun,
shibd,
Technoboy-,
nicoloboschi and
thetumbled
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23876 +/- ##
============================================
+ Coverage 73.57% 74.19% +0.61%
+ Complexity 32624 32205 -419
============================================
Files 1877 1853 -24
Lines 139502 143619 +4117
Branches 15299 16311 +1012
============================================
+ Hits 102638 106551 +3913
+ Misses 28908 28668 -240
- Partials 7956 8400 +444
Flags with carried forward coverage won't be shown. Click here to find out more. |
Technoboy-
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's a test method
BrokerTestUtil.receiveMessagesthat is used in some Key_Shared tests to asynchronously read messages from multiple consumers until no more new messages are arrived after a quiet time.The current implementation is wrong. Currently each consumer is handled separately and if an individual consumer times out, it would stop waiting for new messages even if a recent message arrived on another consumer.
This makes some Key_Shared blocking tests to fail with short time outs. This makes some tests flaky or fail when they shouldn't.
Instead, the quiet time condition should be across all active consumers.
Modifications
Fix the quiet time implementation in
BrokerTestUtil.receiveMessages.Documentation
docdoc-requireddoc-not-neededdoc-complete