Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Clear delayed message when unsubscribe & Make clear operation asynchronous #19901

Merged
merged 6 commits into from
Mar 25, 2023

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Mar 23, 2023

PIP: #16763

Motivation & Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@coderzc coderzc self-assigned this Mar 23, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 23, 2023
@coderzc coderzc added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Mar 23, 2023
@coderzc coderzc added this to the 3.0.0 milestone Mar 23, 2023
@coderzc coderzc changed the title [improve][broker] Make clear delayed message operation asynchronous [improve][broker] Clear delayed message when unsubscribe & Make clear operation asynchronous Mar 23, 2023
@coderzc coderzc closed this Mar 24, 2023
@coderzc coderzc reopened this Mar 24, 2023
@coderzc coderzc force-pushed the improve/bucket_delayed_async_clear branch 7 times, most recently from a49f945 to 7c15617 Compare March 24, 2023 15:33
@coderzc coderzc force-pushed the improve/bucket_delayed_async_clear branch from 7c15617 to c4b95e1 Compare March 25, 2023 07:59
@coderzc coderzc merged commit 329e80b into apache:master Mar 25, 2023
@coderzc coderzc deleted the improve/bucket_delayed_async_clear branch March 25, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants