[improve][broker][PIP-195] Add topicName and cursorName for ledger metadata of bucket snapshot #19802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
changed the title
coderzc
force-pushed
the
improve/bucket_delayed_storage
branch
from
a47a28a to
d4611d1
Compare
coderzc
added
area/broker
type/enhancement
codelipenghui
approved these changes
Mar 14, 2023
|
/pulsarbot run-failure-checks |
Yes, I will update this part of the proposal |
Technoboy-
reviewed
Mar 14, 2023
| @@ -48,7 +48,9 @@ public final class LedgerMetadataUtils { | |||
| private static final String METADATA_PROPERTY_COMPACTEDTO = "pulsar/compactedTo"; | |||
| private static final String METADATA_PROPERTY_SCHEMAID = "pulsar/schemaId"; | |||
|
|
|||
| private static final String METADATA_PROPERTY_DELAYED_INDEX_BUCKETID = "pulsar/delayedIndexBucketId"; | |||
| private static final String METADATA_PROPERTY_DELAYED_INDEX_BUCKET_KEY = "pulsar/delayedIndexBucketKey"; | |||
There was a problem hiding this comment.
Does this change affect getting older values?
There was a problem hiding this comment.
No, we don't read metadata directly, it only used to troubleshoot issues.
coderzc
added a commit
to coderzc/pulsar
that referenced
this pull request
Mar 17, 2023
…tadata of bucket snapshot (apache#19802)
coderzc
added a commit
to coderzc/pulsar
that referenced
this pull request
Mar 17, 2023
…tadata of bucket snapshot (apache#19802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #16763
Motivation & Modifications
add topicName and cursorName for BK metadata of bucket snapshot, so we know who is using the ledger.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: