-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client]sendMessage param miss in createOpSendMsg cause CI Build Error #17297
Conversation
Why the CI doesn't run failed for now? |
I think because we don‘t mandatorily rebase master before merge PR. |
@@ -220,7 +220,7 @@ public OpSendMsg createOpSendMsg() throws IOException { | |||
messageMetadata.copyFrom(messages.get(0).getMessageBuilder()); | |||
ByteBuf encryptedPayload = producer.encryptMessage(messageMetadata, getCompressedBatchMetadataAndPayload()); | |||
ByteBufPair cmd = producer.sendMessage(producer.producerId, messageMetadata.getSequenceId(), | |||
1, messageMetadata, encryptedPayload); | |||
1, messages.get(0).getMessageId(), messageMetadata, encryptedPayload); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right. Are you sure that this is the correct way to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jason918 PTAL. isn't it null
that should be passed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lhotari Actually, both is fine. ShadowReplicator won't use batch producing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lhotari is right
closing this PR, thank you @Nicklee007
Motivation
Fix sendMessage param miss in createOpSendMsg which will cause build error.
Build error cause
https://github.com/apache/pulsar/runs/8032271109?check_suite_focus=true
pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java
Lines 217 to 223 in c13e669
Modifications
Documentation
doc-not-needed
(Please explain why)