[broker][admin]Add api for update topic properties #17238

AnonHxy · 2022-08-23T12:51:46Z

Motivation

Maybe this modification should be part of PIP 110: Topic metadata #12629 . As described in the PIP document "These metadata could be set during topic creation and also updated.", we have implemented the creation method, but have not implement the updated method.
This PR will implement the topic meta update

Modifications

Add a admin api updateProperties

Verifying this change

Make sure that the change passes the CI checks.
Add UT org.apache.pulsar.broker.admin.AdminApi2Test#testUpdatePartitionedTopicProperties
Add UT org.apache.pulsar.broker.admin.AdminApi2Test#testUpdateNonPartitionedTopicProperties

Documentation

Check the box below or label this PR directly.

Need to update docs?

doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)

pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java

Technoboy-

LGTM

pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java

pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java

pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java

Jason918 · 2022-09-04T13:30:45Z

Can you help open a new PR to branch-2.10? There are a lot conflict when cherry-pick directly. @AnonHxy

eolivelli · 2022-09-04T13:32:08Z

@Jason918 we cannot add new APIs on released branches

Jason918 · 2022-09-04T13:34:39Z

@Jason918 we cannot add new APIs on released branches

Sure, I will remove the label.

(cherry picked from commit b21f728)

heesung-sn · 2023-05-19T18:44:58Z

pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java

+
+                    @Override
+                    public void updatePropertiesComplete(Map<String, String> properties, Object ctx) {
+                        managedLedger.getConfig().getProperties().putAll(properties);


managedLedger.getConfig().getProperties() can return NPE if the topic is from the older code without the properties.

Thanks for you to fix it!

* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) (cherry picked from commit 6f8dbc7) * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) (cherry picked from commit 723ad75) * [fix][broker] Fix NPE when update topic properties. ### Motivation In Pulsar 2.10, when creating a producer/consumer that auto-creates a topic and then attempts to update its properties, a NullPointerException (NPE) occurs. The reason is that Pulsar 2.10 does not correctly handle the case when the properties are `null`. ### Modifications Add an NPE check. (cherry picked from commit 0b02321) * remove release profile * import * Revert "remove release profile" This reverts commit 6bec650. --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>

(cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]>

* [broker][admin]Add api for update topic properties (apache#17238) (cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]> * [broker][admin] Add cmd to remove topic properties (apache#17337) * [broker][admin] Add cmd to remove topic properties * address comment * address comment (cherry picked from commit 7075a5c) Signed-off-by: Zixuan Liu <[email protected]> * [fix][broker] Fix NPE when updating topic's properties (apache#17352) Co-authored-by: bjhuxiaohua <[email protected]> (cherry picked from commit f1d1158) --------- Co-authored-by: Xiaoyu Hou <[email protected]> Co-authored-by: Ruguo Yu <[email protected]> Co-authored-by: Flowermin <[email protected]>

Add api for update topic properties

37eadf3

AnonHxy requested review from Technoboy-, codelipenghui and eolivelli August 23, 2022 12:52

AnonHxy added the doc-not-needed Your PR changes do not impact docs label Aug 23, 2022

AnonHxy requested a review from Jason918 August 23, 2022 17:30

AnonHxy self-assigned this Aug 23, 2022

Technoboy- reviewed Aug 24, 2022

View reviewed changes

pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java Outdated Show resolved Hide resolved

Technoboy- approved these changes Aug 24, 2022

View reviewed changes

Technoboy- added this to the 2.12.0 milestone Aug 24, 2022

Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/admin labels Aug 24, 2022

Fix api desc

d3f5d1c

Jason918 reviewed Aug 24, 2022

View reviewed changes

fix comment

b561fa1

Jason918 approved these changes Aug 25, 2022

View reviewed changes

AnonHxy merged commit b21f728 into apache:master Aug 25, 2022

AnonHxy added the release/2.10.2 label Aug 25, 2022

Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Aug 29, 2022

[broker][admin]Add api for update topic properties (apache#17238)

0aa7129

yuruguo mentioned this pull request Aug 29, 2022

[broker][admin] Add cmd to remove topic properties #17337

Merged

1 task

Flowermin mentioned this pull request Aug 30, 2022

[fix][broker] Fix NPE when updating topic properties #17352

Merged

1 task

Jason918 removed the release/2.10.2 label Sep 4, 2022

yuruguo mentioned this pull request Oct 29, 2022

[fix][broker] Modify authorization to update topic's properties #18252

Merged

1 task

liangyepianzhou pushed a commit to streamnative/pulsar-archived that referenced this pull request Mar 1, 2023

[broker][admin]Add api for update topic properties (apache#17238)

b8935c3

(cherry picked from commit b21f728)

yaalsn pushed a commit to streamnative/pulsar-archived that referenced this pull request Mar 1, 2023

[broker][admin]Add api for update topic properties (apache#17238)

7616aaf

(cherry picked from commit b21f728)

liangyepianzhou pushed a commit to streamnative/pulsar-archived that referenced this pull request May 10, 2023

[broker][admin]Add api for update topic properties (apache#17238)

3179143

(cherry picked from commit b21f728)

heesung-sn reviewed May 19, 2023

View reviewed changes

This was referenced May 22, 2023

[fix][broker] managedLedger.getConfig().getProperties().putAll(properties) NPE #20361

Merged

PIP 110: Support Topic metadata - PART-1 create topic with properties #12818

Merged

nodece pushed a commit to nodece/pulsar that referenced this pull request Nov 24, 2023

[broker][admin]Add api for update topic properties (apache#17238)

ee3081d

(cherry picked from commit b21f728) Signed-off-by: Zixuan Liu <[email protected]>

nodece mentioned this pull request Nov 24, 2023

[feat][broker] Update and remove topic properties ascentstream/pulsar#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[broker][admin]Add api for update topic properties #17238

[broker][admin]Add api for update topic properties #17238

AnonHxy commented Aug 23, 2022

Technoboy- left a comment

Jason918 commented Sep 4, 2022

eolivelli commented Sep 4, 2022

Jason918 commented Sep 4, 2022

heesung-sn May 19, 2023

AnonHxy May 23, 2023

[broker][admin]Add api for update topic properties #17238

[broker][admin]Add api for update topic properties #17238

Conversation

AnonHxy commented Aug 23, 2022

Motivation

Modifications

Verifying this change

Documentation

Technoboy- left a comment

Choose a reason for hiding this comment

Jason918 commented Sep 4, 2022

eolivelli commented Sep 4, 2022

Jason918 commented Sep 4, 2022

heesung-sn May 19, 2023

Choose a reason for hiding this comment

AnonHxy May 23, 2023

Choose a reason for hiding this comment