add metric for InMemoryDelayedDeliveryTracker's memory usage #15867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests to be completed. |
github-actions
bot
added
the
doc-required
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
4 tasks
|
@codelipenghui PTAL |
codelipenghui
requested review from
mattisonchao,
eolivelli,
315157973,
codelipenghui,
BewareMyPower,
congbobo184,
gaoran10 and
Technoboy-
...broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java
Outdated
Show resolved
Hide resolved
...ar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java
Outdated
Show resolved
Hide resolved
...ar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java
Outdated
Show resolved
Hide resolved
...ar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java
Show resolved
Hide resolved
...ar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java
Outdated
Show resolved
Hide resolved
...ar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java
Show resolved
Hide resolved
...ar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java
Outdated
Show resolved
Hide resolved
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/TopicStatsImpl.java
Outdated
Show resolved
Hide resolved
…delayed_delivery_memory � Conflicts: � pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java � pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/PersistentTopicTest.java
|
/pulsarbot run-failure-checks |
…delayed_delivery_memory � Conflicts: � pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
|
/pulsarbot run-failure-checks |
hezhangjian
reviewed
Jul 27, 2022
...broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/AggregatedNamespaceStats.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TopicStats.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Jul 28, 2022
|
@tjiuming Please check @Shoothzj 's comments |
mattisonchao
approved these changes
Jul 29, 2022
|
/pulsarbot run-failure-checks |
|
@codelipenghui All CI checks passed, PTAL |
Anonymitaet
added
doc-complete
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
4 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Provide namespace level and topic level metric for
InMemoryDelayedDeliveryTracker'smemory usage.Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)