-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Use shrink map for message redelivery. #15342
Merged
Technoboy-
merged 2 commits into
apache:master
from
Technoboy-:replace-to-common-long-map
Apr 28, 2022
Merged
[improve][broker] Use shrink map for message redelivery. #15342
Technoboy-
merged 2 commits into
apache:master
from
Technoboy-:replace-to-common-long-map
Apr 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added release labels, it's a serious problem that will cause the thread |
codelipenghui
approved these changes
Apr 27, 2022
mattisonchao
approved these changes
Apr 27, 2022
Jason918
approved these changes
Apr 28, 2022
BewareMyPower
approved these changes
Apr 28, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Apr 28, 2022
(cherry picked from commit 615f05a)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 28, 2022
(cherry picked from commit 615f05a)
codelipenghui
pushed a commit
that referenced
this pull request
Apr 29, 2022
(cherry picked from commit 615f05a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.8
Archived: 2.8 is end of life
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
doc-not-needed
Your PR changes do not impact docs
release/2.8.4
release/2.9.3
release/2.10.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes the messages sent to consumers are delayed over 100ms and we find that the CPU is wasted on :
Then we find there are many empty datas in the map from dump :
![image](https://user-images.githubusercontent.com/6297296/165461606-9e803243-174b-4fc5-835a-5e9da9bca48a.png)
As #14515 has introduced shrink map, it's better to use it to avoid iterator the empty data.
Documentation
no-need-doc