Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiered Storage: add OkHttp based provider for JClouds #15136

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

eolivelli
Copy link
Contributor

Motivation

In some test environment I have seen a problem using Apache HC based Driver.
I have filed this bug https://issues.apache.org/jira/browse/JCLOUDS-1605

Unfortunately the JClouds Apache HC driver looks not maintained.
The OkHttp based provider seems to work well and to not suffer from the problems reported using the standard HttpUrlConnection based Driver (hung TLS connections).

This patch disables Apache HC driver, adds the OkHttp driver, but both of them are disabled.

Modifications

  • add support for jclouds-okhttp
  • you can enable it with -Dpulsar.jclouds.use_okhttp=true
  • disable by default Apache HC based driver (pulsar.jclouds.use_apache_hc is now false by default)

Verifying this change

Unfortunately this change can be tested only manually

Copy link
Member

@dave2wave dave2wave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The situation with jClouds is unfortunate.

@eolivelli
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better rollback the pulsar.jclouds.use_apache_hc driver introduced by #15105

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit a74527d into apache:master Apr 14, 2022
lhotari pushed a commit to datastax/pulsar that referenced this pull request Apr 14, 2022
aparajita89 pushed a commit to aparajita89/pulsar that referenced this pull request Apr 18, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Apr 28, 2022
lhotari pushed a commit to datastax/pulsar that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tieredstorage doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants