-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiered Storage: add OkHttp based provider for JClouds #15136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The situation with jClouds is unfortunate.
/pulsarbot rerun-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better rollback the pulsar.jclouds.use_apache_hc driver introduced by #15105
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit a74527d)
(cherry picked from commit a74527d)
(cherry picked from commit a74527d)
Motivation
In some test environment I have seen a problem using Apache HC based Driver.
I have filed this bug https://issues.apache.org/jira/browse/JCLOUDS-1605
Unfortunately the JClouds Apache HC driver looks not maintained.
The OkHttp based provider seems to work well and to not suffer from the problems reported using the standard HttpUrlConnection based Driver (hung TLS connections).
This patch disables Apache HC driver, adds the OkHttp driver, but both of them are disabled.
Modifications
Verifying this change
Unfortunately this change can be tested only manually