KCA: Option to sanitize topic name for the connectors that cannot handle pulsar topic names #14475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle pulsar topic names
github-actions
bot
added
the
doc
eolivelli
requested changes
Feb 27, 2022
...kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSink.java
Show resolved
Hide resolved
lhotari
requested review from
hezhangjian,
lhotari,
congbobo184 and
michaeljmarshall
lhotari
approved these changes
Feb 28, 2022
michaeljmarshall
approved these changes
Feb 28, 2022
...t-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/PulsarKafkaConnectSinkConfig.java
Show resolved
Hide resolved
4 tasks
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2022
…dle pulsar topic names (apache#14475) Some kafka connectors do not sanitize topic names (or incompletely do) to match what downstream system supports. It works in kafka in most cases, assuming appropriately named topics. This does not work well with Kafka Connect Adaptor because URI part is getting there. * Flag to sanitize the topic name (disabled by default) and corresponding functionality. * test - [ ] Make sure that the change passes the CI checks. - added unit test - verified with specific connector that didn't work without this change *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) - The rest endpoints: (yes / no) - The admin cli options: (yes / no) - Anything that affects deployment: (yes / no / don't know) Check the box below or label this PR directly (if you have committer privilege). Need to update docs? - [ ] `doc-required` (If you need help on updating docs, create a doc issue) - [ ] `no-need-doc` (Please explain why) - [x] `doc` Config parameter documented in FieldDoc. (cherry picked from commit fd9e639)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2022
…dle pulsar topic names (apache#14475) Some kafka connectors do not sanitize topic names (or incompletely do) to match what downstream system supports. It works in kafka in most cases, assuming appropriately named topics. This does not work well with Kafka Connect Adaptor because URI part is getting there. * Flag to sanitize the topic name (disabled by default) and corresponding functionality. * test - [ ] Make sure that the change passes the CI checks. - added unit test - verified with specific connector that didn't work without this change *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) - The rest endpoints: (yes / no) - The admin cli options: (yes / no) - Anything that affects deployment: (yes / no / don't know) Check the box below or label this PR directly (if you have committer privilege). Need to update docs? - [ ] `doc-required` (If you need help on updating docs, create a doc issue) - [ ] `no-need-doc` (Please explain why) - [x] `doc` Config parameter documented in FieldDoc. (cherry picked from commit fd9e639)
eolivelli
pushed a commit
that referenced
this pull request
Mar 22, 2022
…dle pulsar topic names (#14475) ### Motivation Some kafka connectors do not sanitize topic names (or incompletely do) to match what downstream system supports. It works in kafka in most cases, assuming appropriately named topics. This does not work well with Kafka Connect Adaptor because URI part is getting there. ### Modifications * Flag to sanitize the topic name (disabled by default) and corresponding functionality. * test ### Verifying this change - [ ] Make sure that the change passes the CI checks. - added unit test - verified with specific connector that didn't work without this change ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) - The rest endpoints: (yes / no) - The admin cli options: (yes / no) - Anything that affects deployment: (yes / no / don't know) ### Documentation Check the box below or label this PR directly (if you have committer privilege). Need to update docs? - [ ] `doc-required` (If you need help on updating docs, create a doc issue) - [ ] `no-need-doc` (Please explain why) - [x] `doc` Config parameter documented in FieldDoc. (cherry picked from commit fd9e639)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…dle pulsar topic names (apache#14475) ### Motivation Some kafka connectors do not sanitize topic names (or incompletely do) to match what downstream system supports. It works in kafka in most cases, assuming appropriately named topics. This does not work well with Kafka Connect Adaptor because URI part is getting there. ### Modifications * Flag to sanitize the topic name (disabled by default) and corresponding functionality. * test ### Verifying this change - [ ] Make sure that the change passes the CI checks. - added unit test - verified with specific connector that didn't work without this change ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) - The rest endpoints: (yes / no) - The admin cli options: (yes / no) - Anything that affects deployment: (yes / no / don't know) ### Documentation Check the box below or label this PR directly (if you have committer privilege). Need to update docs? - [ ] `doc-required` (If you need help on updating docs, create a doc issue) - [ ] `no-need-doc` (Please explain why) - [x] `doc` Config parameter documented in FieldDoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some kafka connectors do not sanitize topic names (or incompletely do) to match what downstream system supports.
It works in kafka in most cases, assuming appropriately named topics. This does not work well with Kafka Connect Adaptor because URI part is getting there.
Modifications
Verifying this change
Make sure that the change passes the CI checks.
added unit test
verified with specific connector that didn't work without this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
docConfig parameter documented in FieldDoc.