[Functions] Enable poolMessages of functions by default #13254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed test |
|
The pr had no activity for 30 days, mark with Stale label. |
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have introduced poolMessages for consumer by PIP-83, and add configuration for functions by #11618
The default value of poolMessage is false if user did not config it in
FunctionConfig.It's better to enable poolMessage for function instance to avoid high work load of JVM GC. And user do not need to call release API for each messages, we have already did that in function instance side.
For those user developing functions, they do not need to known the detail of memory usage with poolMessage and whether they need to enable poolMessage when create functions.
Modifications
Enable poolMessages of functions by default
Verifying this change
This change is already covered by existing tests, such as testPoolMessages()
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docOnly change default value