-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[broker] Cancel scheduled tasks when deleting ManagedLedgerImpl #12565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Nov 1, 2021
@lhotari This PR may need cherry pick to other branches |
lhotari
pushed a commit
that referenced
this pull request
Dec 9, 2021
(cherry picked from commit a95a382)
lhotari
pushed a commit
that referenced
this pull request
Dec 9, 2021
(cherry picked from commit a95a382)
lhotari
pushed a commit
that referenced
this pull request
Dec 9, 2021
(cherry picked from commit a95a382)
thanks for the heads up @Shoothzj . I have cherry-picked to branch-2.7, branch-2.8 and branch-2.9 . /cc @315157973 @eolivelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.7
Archived: 2.7 is end of life
cherry-picked/branch-2.8
Archived: 2.8 is end of life
cherry-picked/branch-2.9
Archived: 2.9 is end of life
doc-not-needed
Your PR changes do not impact docs
release/2.7.4
release/2.8.2
release/2.9.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If we delete a persistent topic, the following error may be output to the broker log 4 hours later.
This happens because a task that regularly rolls over a ledger attempts to close already deleted one. This task is canceled when the
ManagedLedgerImpl
is closed, but not when it is deleted.Modifications
Cancel
checkLedgerRollTask
not only when closingManagedLedgerImpl
, but also when deleting it.Verifying this change
Does this pull request potentially affect one of the following parts:
Documentation
Check the box below and label this PR (if you have committer privilege).
no-need-doc