Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build viable Docker images for Polaris using Quarkus #610
Build viable Docker images for Polaris using Quarkus #610
Changes from all commits
448f212
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is different, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different, but I think
apache/polaris
is more correct :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly,
localhost:5001
is definitely not a good choice. This is only useful if you have a local registry running, but images with that kind of registry are otherwise unusable.Since @jbonofre created our DockerHub space: https://hub.docker.com/r/apache/polaris, the official polaris image name will be
apache/polaris
- which expands todocker.io/apache/polaris
.This is the name I'm using consistently in this PR. E.g. if you build the images as of today with
./gradlew assemble -Dquarkus.container-image.build=true
you would get the following images loaded in your Docker environment:apache/polaris:latest
apache/polaris:1.0.0-incubating-SNAPSHOT
apache/polaris-admin-tool:latest
apache/polaris-admin-tool:1.0.0-incubating-SNAPSHOT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are not including any JDBC drivers anymore; we now need this hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a fair trade-off to me.