Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of metadata API with timestamp tracking capabilities. #1725

Closed
wants to merge 0 commits into from

Conversation

splatch
Copy link
Contributor

@splatch splatch commented Aug 9, 2024

Introduction of tag metadata which serves similar purpose to result set metadata for JDBC, but with constraints on key syntax. Softly related to #1471 and other drivers which are capable of providing timestamp information as a part of message exchanges.

In order to force registration of metadata keys, so they can be identified by callers, if needed, keys have non-string form.

Feature been discussed recently in this thread:
https://lists.apache.org/thread/chc1p0czm7q33n1r57zbw7h11c7wzp4l
but origins of feature come from older thread:
https://lists.apache.org/thread/r3g4y6p7kst7z5bdpmccd8538h3hl80f

@splatch splatch requested a review from chrisdutz August 9, 2024 17:50
@splatch splatch self-assigned this Aug 9, 2024
@chrisdutz
Copy link
Contributor

I'm on holidays this week can have a look next Friday.

@chrisdutz
Copy link
Contributor

It does feel a bit different from the other parts of our API ... but I guess I would simply need to play around with it a bit. I gess we can always change things in the future, if we want to give all parts the same feel.

Copy link
Contributor

@chrisdutz chrisdutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@splatch splatch marked this pull request as ready for review September 24, 2024 16:15
@splatch splatch force-pushed the resultset-metadata branch 4 times, most recently from 6997913 to 4d590d3 Compare October 25, 2024 15:37
@splatch
Copy link
Contributor Author

splatch commented Oct 25, 2024

@chrisdutz FYI I've separated API and SPI parts, now it is a bit closer to overall paradigm we have. Still metadata is immutable and a bit constrained in manipulation to avoid 1) putting too much there 2) relying too much on it.

@splatch splatch closed this Oct 25, 2024
@splatch splatch force-pushed the resultset-metadata branch from 4d590d3 to 862efa5 Compare October 25, 2024 17:37
@splatch splatch deleted the resultset-metadata branch October 25, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants