Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CollectionUtil toSeq methods #1510

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix CollectionUtil toSeq methods #1510

merged 1 commit into from
Oct 1, 2024

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Oct 1, 2024 •
edited
Loading

This PR fixes the the newly added .toSeq methods in #1491, more specifically

  • Adds the pekko @InternalApi annotation since the private[package] doesn't work in Java
  • Moves the scala-2.13+ to just scala-2.13 and adds an implementation bespoke to scala-3. This is because @inline doesn't do anything in Scala 3, instead you have to use the new inline keyword.

@mdedetrich
Fix CollectionUtil toSeq methods
b05ff10 
Signed-off-by: Matthew de Detrich <[email protected]>
@mdedetrich mdedetrich requested a review from pjfanning October 1, 2024 10:23
pjfanning
pjfanning approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich mdedetrich merged commit bc32e04 into apache:main Oct 1, 2024
9 checks passed
@mdedetrich mdedetrich deleted the fix-collection-util-toseq-methods branch October 1, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjfanning pjfanning pjfanning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdedetrich @pjfanning