Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protect 1.1.x branch #631

Merged
merged 1 commit into from
Nov 27, 2024
Merged

protect 1.1.x branch #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .asf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,18 @@ github:
dismiss_stale_reviews: false
require_code_owner_reviews: false
required_approving_review_count: 1
1.1.x:
required_status_checks:
# strict means "Require branches to be up to date before merging".
strict: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that the default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure - but we set it explicitly elsewhere

# contexts are the names of checks that must pass
contexts:
- Code is formatted
- Check headers
required_pull_request_reviews:
dismiss_stale_reviews: false
require_code_owner_reviews: false
required_approving_review_count: 1
1.0.x:
required_status_checks:
# strict means "Require branches to be up to date before merging".
Expand Down
Loading