Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: install sbt #619

Merged
merged 2 commits into from
Oct 14, 2024
Merged

CI: install sbt #619

merged 2 commits into from
Oct 14, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Oct 13, 2024

We can no longer rely on sbt being pre-installed in CI envs.

https://eed3si9n.com/setup-sbt/

see broken jobs in https://github.com/apache/pekko-http/pull/618/checks

ubuntu-latest is now ubuntu-24 and as documented in the eed3si9n.com article, that does not have sbt pre-installed

we use a lot of different versions of ubuntu in our builds - change to use ubuntu 22 as a min

@samueleresca
Copy link
Member

sbt should be still available in 22.04 ubuntu images though: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#project-management

@samueleresca
Copy link
Member

samueleresca commented Oct 13, 2024

Also:

bt/setup-sbt@v1 is not allowed to be used in apache/pekko-http. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following: 
*/*@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+, AdoptOpenJDK/install-jdk@*, JamesIves/github-pages-
deploy-action@5dc1d5a192aeb5ab5b7d5a77b7d36aea4a7f5c92, TobKed/label-when-approved-action@*, actions-
cool/issues-helper@*, actions-rs/*, al-cheb/configure-pagefile-action@*, amannn/action-semantic-pull-request@*, 
apache/*, burrunan/gradle-cache-action@*, bytedeco/javacpp-presets/.github/actions/*, chromaui/action@*, 
codecov/codecov-action@*, conda-incubator/setup-miniconda@*, container-tools/kind-action@*, container-
tools/microshift-action@*, dawidd6/action-download-artifact@*, delaguardo/setup-graalvm@*, docker://jekyll/jekyll:*, 
docker://pandoc/core:2.9, eps1lon/actions-label-merge-conflict@*, gaurav-nelson/github-action-markdown-l...

Do we have restriction on the allowed GH action in the repo within the apache org? We might need to open a infra ticket?

@pjfanning
Copy link
Contributor Author

@samueleresca ASF Infra team approves CI actions on a case by case basis. I will raise a JIRA with them.

more changes
@pjfanning
Copy link
Contributor Author

ASF Infra have approved the sbt/setup-sbt action

@raboof raboof merged commit 1b1a960 into apache:main Oct 14, 2024
10 checks passed
@pjfanning pjfanning deleted the ci-sbt branch October 14, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants