Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix Akka HTTP versions #342

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

pjfanning
Copy link
Contributor

a few version numbers lacking Akka prefixing

mdedetrich
mdedetrich previously approved these changes Oct 24, 2023
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also backport this

@mdedetrich mdedetrich dismissed their stale review October 24, 2023 17:57

Need to run javafmt

@mdedetrich
Copy link
Contributor

@pjfanning You need to run javafmt

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also backport

@pjfanning pjfanning merged commit 6df57df into apache:main Oct 24, 2023
9 of 10 checks passed
@pjfanning pjfanning deleted the deprecation-versions branch October 24, 2023 20:30
pjfanning added a commit to pjfanning/incubator-pekko-http that referenced this pull request Oct 24, 2023
* prefix Akka HTTP versions

* javafmt
pjfanning added a commit that referenced this pull request Oct 24, 2023
* prefix Akka HTTP versions

* javafmt
He-Pin pushed a commit to He-Pin/incubator-pekko-http that referenced this pull request Dec 24, 2023
* prefix Akka HTTP versions

* javafmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants