!sbt Use multiJvmPlugin from pekko.

[He-Pin]

Just copy code from pekko, better to submit this upstream, will do later.

[pjfanning]

approved as temporary solution - if it doesn't help, we should probably revert this - if it does work, we should be looking at creating a shared sbt plugin with this change

[jrudolph]

What problem does it solve?

[He-Pin]

What problem does it solve?

It start the Player only after The Controller can be connected.

Otherwise a connection refused may be raised and the test is failed.

[mdedetrich]

approved as temporary solution - if it doesn't help, we should probably revert this - if it does work, we should be looking at creating a shared sbt plugin with this change

@pjfanning This is probably a good candidate to include in the incubator-pekko-sbt-build I was talking about

[He-Pin]

That's true, the sbt one seems unmaintained at least for now.

[mdedetrich]

That's true, the sbt one seems unmaintained at least for now.

I assume you are talking about https://github.com/sbt/sbt-multi-jvm? If so do you know for what reasons we aren't using this plugin, i.e. is it missing anything? Rather than having all of this extra code that we have to maintain ourselves its always ideal to use an upstream version and while its true that it hasn't really been maintained, the current sbt maintainers are very responsive when it comes to accepting upstream PR's.

If its shown that you are doing extensive contributions to an sbt community project they can add you as maintainers (I am already a maintainer for sbt-github-actions for example).

[He-Pin]

@mdedetrich

1. We need wait the Controller transited to connectable before start the Player.
2. Need submit a PR to sbt-multi-jvm and waiting a new snapshot, which may take sometimes and is not a quick fix.
3. I did not diff the code with sbt-multi-jvm line by line, but there must be some reason for Akka was keep it separately

[mdedetrich]

@He-Pin Lets discuss in apache/pekko#548

[jrudolph]

Where did the problem occur and how was it fixed? Which kubernetes cluster are we connecting against here? Matthew de Detrich ***@***.***> schrieb am Di., 8. Aug. 2023, 09:12:

…

@He-Pin <https://github.com/He-Pin> Lets discuss in apache/pekko#548 <apache/pekko#548> — Reply to this email directly, view it on GitHub <#297 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACNDEG5VDHOCYWBI3UUMDXUHRHTANCNFSM6AAAAAA3G73I7A> . You are receiving this because you commented.Message ID: ***@***.***>

[He-Pin]

Let's me submit a fix and then this code will not be needed.