Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add advice on how to run tests #322

Merged
merged 5 commits into from
Jan 23, 2024
Merged

add advice on how to run tests #322

merged 5 commits into from
Jan 23, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Jan 22, 2024 •
edited
Loading

also covers #320

@pjfanning pjfanning marked this pull request as draft January 22, 2024 16:18
@pjfanning pjfanning marked this pull request as ready for review January 22, 2024 18:46
mdedetrich
mdedetrich approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can always make future improvements

nvollmar
nvollmar approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

He-Pin
He-Pin approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit e6f4278 into main Jan 23, 2024
49 of 50 checks passed
@pjfanning pjfanning deleted the running-tests branch January 23, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He-Pin He-Pin He-Pin approved these changes

@nvollmar nvollmar nvollmar approved these changes

@mdedetrich mdedetrich mdedetrich approved these changes

@samueleresca samueleresca Awaiting requested review from samueleresca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pjfanning @He-Pin @nvollmar @mdedetrich