Use scope config for compute-engine auth #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
requested review from
gmethvin,
He-Pin,
pjfanning,
jxnu-liguobin,
jrudolph and
seglo
|
you'll need something like https://github.com/apache/incubator-pekko-connectors/pull/311/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91R16 to get the mima check to work - v1.0.2-RC1 is current latest tag and this is only in staging repo - this PR looks like it could have a small but non-zero mima footprint |
He-Pin
reviewed
Jan 14, 2024
...src/main/scala/org/apache/pekko/stream/connectors/google/auth/ComputeEngineCredentials.scala
Show resolved
Hide resolved
mdedetrich
force-pushed
the
propagate-scope-config-to-compute-engine-credentials
branch
from
67eea4f to
945a56e
Compare
|
@pjfanning @He-Pin You mind re-reviewing this? There aren't any actual MiMa issues (I just rebased off of |
mdedetrich
deleted the
propagate-scope-config-to-compute-engine-credentials
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when getting Google credentials using the
ComputeEngineCredentialsmethod, it ignores thescopesvariable.In the official Google SDK, you can see that it also has the same logic for getting the credentials from
ComputeEngine, see https://github.com/googleapis/google-auth-library-java/blob/a7a8d7a4102b0b7c1b83791947ccb662f060eca7/oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java#L193-L199 and https://github.com/googleapis/google-auth-library-java/blob/a7a8d7a4102b0b7c1b83791947ccb662f060eca7/oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java#L480-L483 (which is the same URI as https://github.com/apache/incubator-pekko-connectors/blob/67eea4f1dc7e9e0931322ef5c07f305e995b0eb2/google-common/src/main/scala/org/apache/pekko/stream/connectors/google/auth/GoogleComputeMetadata.scala#L33-L34)