Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant formatting sbt settings #299

Merged

Conversation

mdedetrich
Copy link
Contributor

We have long since removed the concept of formatting sources on compile in all of the Pekko modules, furthermore setting these settings are redundant anyways since they default to false anyways.

@mdedetrich mdedetrich force-pushed the remove-redundant-format-sbt-settings branch from a891d45 to 85a0ef3 Compare December 29, 2023 10:54
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich mdedetrich merged commit b04de53 into apache:main Dec 29, 2023
49 of 50 checks passed
@mdedetrich mdedetrich deleted the remove-redundant-format-sbt-settings branch December 29, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants