Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also test with pekko 1.1 #293

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Dec 22, 2023

  • need to test with pekko 1.0 and 1.1

@pjfanning pjfanning marked this pull request as draft December 22, 2023 12:51
@pjfanning pjfanning changed the title [DRAFT] Test different pekko versions Also test with pekko 1.1 Dec 22, 2023
@pjfanning pjfanning marked this pull request as ready for review December 22, 2023 20:56
@pjfanning pjfanning requested review from mdedetrich, He-Pin, nvollmar and samueleresca and removed request for mdedetrich December 22, 2023 20:59
Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin
Copy link
Member

He-Pin commented Dec 23, 2023

@pjfanning Do we need a runner for Java 21 too? People may jump from Java 8 to Java 21, I think test these two should be OK.

@pjfanning
Copy link
Contributor Author

@pjfanning Do we need a runner for Java 21 too? People may jump from Java 8 to Java 21, I think test these two should be OK.

I've updated the 1.1 job to test with multiple JDKs

@pjfanning pjfanning added this to the 1.0.2 milestone Dec 23, 2023
@mdedetrich
Copy link
Contributor

@pjfanning Is it possible to do the source code changes (i.e. moving the deprecated) in another PR rather than this one? If its not related to adding testing for Pekko 1.0/1.1 I would rather keep the commits separate otherwise its confusing when we need to look back.

temporarily test with pekko main snapshot

Update build.sbt

logback issue

sbt-pekko-build 1.0.2

add nightly job

Update nightly-pekko-1.1-builds.yaml

Update nightly-pekko-1.1-builds.yaml

multiple jdks

temp run for pull request

Update KinesisTest.java

Update nightly-pekko-1.1-builds.yaml

Update nightly-pekko-1.1-builds.yaml

deprecation issue

Update DirectoryChangesSource.java

Update nightly-pekko-1.1-builds.yaml

Revert "Update DirectoryChangesSource.java"

This reverts commit 1b1932a.

Revert "deprecation issue"

This reverts commit 2b41b26.

Revert "Update KinesisTest.java"

This reverts commit a7c472f.

Revert "temp run for pull request"

This reverts commit c92b62d.
@pjfanning pjfanning force-pushed the test-different-pekko-versions branch from 1b1932a to 1540677 Compare December 23, 2023 22:52
@pjfanning
Copy link
Contributor Author

@mdedetrich I've dropped the code changes for java 17/21. They will be done later.

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 44b465e into apache:main Dec 23, 2023
49 of 50 checks passed
@pjfanning pjfanning deleted the test-different-pekko-versions branch December 23, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants