Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: night build matrix #193

Merged
merged 4 commits into from
Jun 4, 2024
Merged

fix: night build matrix #193

merged 4 commits into from
Jun 4, 2024

Conversation

Roiocam
Copy link
Member

@Roiocam Roiocam commented Jun 4, 2024

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Roiocam Roiocam marked this pull request as draft June 4, 2024 09:43

- name: Cache Coursier cache
uses: coursier/cache-action@v6

- name: Run tests with Scala ${{ matrix.scala-version }} and Java ${{ matrix.java-version }} with Pekko ${{ matrix.pekko-version }}
run: sbt -Dpekko.build.pekko.version=${{ matrix.pekko-version }} "++${{ matrix.scala-version }} test"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is missing here.

@Roiocam
Copy link
Member Author

Roiocam commented Jun 4, 2024

@pjfanning, it looks like you approved this before this PR is ready for review. can you take a look again? the nightly build seems to have passed.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@Roiocam Roiocam marked this pull request as ready for review June 4, 2024 10:32
@Roiocam Roiocam merged commit eb2a212 into apache:main Jun 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run nightly tests
2 participants