Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty file with list data #23

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

novemberkilo
Copy link
Contributor

Please see apache/arrow-rs#1448 (comment) for context

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sunchao
Copy link
Member

sunchao commented Mar 17, 2022

cc @pitrou

@pitrou
Copy link
Member

pitrou commented Mar 17, 2022

Can you please add a line describing the file here: https://github.com/apache/parquet-testing/blob/master/data/README.md?

@pitrou
Copy link
Member

pitrou commented Mar 17, 2022

Also, it would be nice if this was paired with a JIRA ticket at https://issues.apache.org/jira/projects/PARQUET/

@novemberkilo
Copy link
Contributor Author

@pitrou thanks for reviewing - I've added a description.

@pitrou pitrou changed the title Adds emptylist. Add empty file with list data Mar 21, 2022
@pitrou pitrou merged commit 7175a47 into apache:master Mar 21, 2022
@pitrou
Copy link
Member

pitrou commented Mar 21, 2022

Thanks for contributing this @novemberkilo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants