Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3 #859

Merged
merged 2 commits into from
Feb 4, 2021
Merged

PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3 #859

merged 2 commits into from
Feb 4, 2021

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 30, 2021

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    This PR should pass the existing UTs and passed all UTs.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Copy link
Contributor

@gszadovszky gszadovszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are a couple unrelated Travis failures for our PRs. Let's wait for a green build.

@dongjoon-hyun
Copy link
Member Author

Thank you for reviews.

@dongjoon-hyun
Copy link
Member Author

Do I need to rebase this PR to see the green build?

Let's wait for a green build.

@dongjoon-hyun dongjoon-hyun changed the title PARQUET-1967: Upgrade Zstd-jni to 1.4.8-2 PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3 Feb 2, 2021
@gszadovszky
Copy link
Contributor

@dongjoon-hyun, you don't need to rebase, I've already re-triggered the build. I don't know what's happening with Travis but there are unrelated failures and stuck builds in the system for several PRs. I hope, it'll be solved soon.

@dongjoon-hyun
Copy link
Member Author

Got it. Thank you, @gszadovszky !

@gszadovszky
Copy link
Contributor

Close/re-open this PR to trigger the newly configured github action.

@gszadovszky gszadovszky closed this Feb 3, 2021
@gszadovszky gszadovszky reopened this Feb 3, 2021
@dongjoon-hyun
Copy link
Member Author

Thank you for retriggering, @gszadovszky !

@gszadovszky gszadovszky merged commit 2b73ce3 into apache:master Feb 4, 2021
@dongjoon-hyun
Copy link
Member Author

Thank you so much!

@dongjoon-hyun dongjoon-hyun deleted the PARQUET-1967 branch February 4, 2021 18:27
@gszadovszky
Copy link
Contributor

gszadovszky commented Feb 5, 2021

Thank you for the contribution, @dongjoon-hyun! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants