ORC-1019: Remove redundant jackson dependencies

[guiyanakuang]

What changes were proposed in this pull request?

This PR aims to remove redundant jackson dependencies.
Unfortunately, ORC-946 forgot to remove the bench dependency on jackson. In fact, the bench module does not directly depend on jackson, only spark indirectly depends on the specified version of jackson.

Why are the changes needed?

Minimising dependencies.

How was this patch tested?

Pass the CIs.

Closes #928

[dongjoon-hyun]

Thank you for making a PR, @guiyanakuang . BTW, this looks like a revert of ORC-807 (from @belugabehr )

So, is this the current status, @guiyanakuang ?

In fact, the bench module does not directly depend on jackson, only spark indirectly depends on the specified version of jackson.

[guiyanakuang]

Thank you for making a PR, @guiyanakuang . BTW, this looks like a revert of ORC-807 (from @belugabehr )

So, is this the current status, @guiyanakuang ?

In fact, the bench module does not directly depend on jackson, only spark indirectly depends on the specified version of jackson.

Yes, because the code that depends on jackson has been rewritten with gson in ORC-946. I'm sure this is the current state.

Comment before update: which reminds me that we don't even need to declare Spark's dependency on jackson, there is no conflict.
I immediately made a new commit to remove the explicit dependency of spark on jackson.

update: I was wrong, actually spark and avro depend on different versions of jackson in orc-benchmarks-spark, explicit dependencies are better than letting maven choose based on the length of the dependency path, I think it's better to keep it.

[dongjoon-hyun]

Ya, I agree with your updated opinion, @guiyanakuang . Then, shall we close this PR?

[dongjoon-hyun]

Since you investigated this, please take over #928.
If you make a PR, I will merge yours.

The bot is only reducing the human-labor to check the new versions. So, the main contribution is the human review and investigation. Thank you for your review on #928 and investigation on this. I really appreciate your passion and contribution, @guiyanakuang .

[guiyanakuang]

@dongjoon-hyun. Sorry, I didn't make my point clearly.
My updated view is to keep the orc-benchmarks-spark dependency unchanged, but we can remove the jackson dependency from the overall definition of the bench, as we don't explicitly use jakcson in the bench anymore, and the previous part in orc-benchmarks-core was already rewritten using gson rewrites the So my view is to use this pr instead of bot. This pr still retains the explicit specification of jackson by orc-benchmarks-spark. 😄

[dongjoon-hyun]

Got it, @guiyanakuang !

[dongjoon-hyun]

+1, LGTM.

[dongjoon-hyun]

Merged to main for Apache ORC 1.8.

BTW, one tip for you, @guiyanakuang .
When we override another PR, you can use Closes #928 at the bottom of PR description.
It will close that specific PR when this PR get merged.

For this PR, I revised the PR description and merged it.

[guiyanakuang]

Merged to main for Apache ORC 1.8.

BTW, one tip for you, @guiyanakuang . When we override another PR, you can use Closes #928 at the bottom of PR description. It will close that specific PR when this PR get merged.

For this PR, I revised the PR description and merged it.

Got it, hahaha, thank you @dongjoon-hyun .